Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for fallback domains #1356

Merged
merged 18 commits into from
Jan 13, 2022
Merged

Adding support for fallback domains #1356

merged 18 commits into from
Jan 13, 2022

Conversation

kjhandy
Copy link
Contributor

@kjhandy kjhandy commented Dec 22, 2021

No description provided.

patryk
patryk requested changes Dec 22, 2021
View reviewed changes
Copy link
Contributor

@patryk patryk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing documentation, tests failing, improper cloudflare-go fields usage.

@patryk patryk added kind/enhancement Categorizes issue or PR as related to improving an existing feature. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/new-resource Categorizes issue or PR as related to creating a new resource. workflow/pending-contributor-response Indicates an issue or PR requires a response from a contributor. workflow/pending-op-response Indicates an issue or PR requires a response from the original poster. labels Dec 22, 2021
@kjhandy
Copy link
Contributor Author

kjhandy commented Dec 22, 2021

Added documentation. Tests should all pass once cloudflare-go is bumped (depends on cloudflare/cloudflare-go#761).

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2022

Marking this pull request as stale due to 14 days of inactivity. This helps our maintainers find and focus on the active pull requests. If this pull request receives no comments in the next 7 days it will automatically be closed. Maintainers can also remove the lifecycle/stale label.
If this pull request was automatically closed and you feel this pull request should be reopened, we encourage creating a new pull request linking back to this one for added context. Thank you!

@kjhandy
Copy link
Contributor Author

kjhandy commented Jan 6, 2022

@patryk I believe this is waiting on a cloudflare-go release and to bump the version here. Is there a plan to do that?

jacobbednarz
jacobbednarz reviewed Jan 13, 2022
View reviewed changes
cloudflare/resource_cloudflare_fallback_domain.go Outdated
Update: resourceCloudflareFallbackDomainUpdate,
Delete: resourceCloudflareFallbackDomainDelete,
Importer: &schema.ResourceImporter{
State: schema.ImportStatePassthrough,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! this actually found a bug 🤗 we have defined resourceCloudflareFallbackDomainImport but not used it.

@jacobbednarz jacobbednarz removed workflow/pending-contributor-response Indicates an issue or PR requires a response from a contributor. workflow/pending-op-response Indicates an issue or PR requires a response from the original poster. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. labels Jan 13, 2022
@jacobbednarz jacobbednarz merged commit fc76b4d into cloudflare:master Jan 13, 2022
@jacobbednarz jacobbednarz mentioned this pull request Jan 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobbednarz jacobbednarz jacobbednarz left review comments

@patryk patryk patryk requested changes

Assignees
No one assigned
Labels
kind/enhancement Categorizes issue or PR as related to improving an existing feature. kind/new-resource Categorizes issue or PR as related to creating a new resource.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kjhandy @patryk @jacobbednarz