Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/cloudflare_zone: support setting type #1301

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

jacobbednarz
Copy link
Member

Updates the cloudflare_zone resource to support setting the zone type
when creating and updating the resource.

Fixes #1277

Updates the `cloudflare_zone` resource to support setting the zone type
when creating and updating the resource.

Fixes #1277

Co-Authored-By: Eric Herot <[email protected]>
@jacobbednarz jacobbednarz force-pushed the allow-setting-zone-type branch from 1a31b61 to 2d0a8dd Compare November 5, 2021 03:53
@jacobbednarz
Copy link
Member Author

acceptance tests are all green

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./...) -v -run "^TestAccCloudflareZone_" -count 1 -parallel 1 -timeout 120m -parallel 1
?   	github.com/cloudflare/terraform-provider-cloudflare	[no test files]
=== RUN   TestAccCloudflareZone_PreventZoneIdAndNameConflicts
=== PAUSE TestAccCloudflareZone_PreventZoneIdAndNameConflicts
=== RUN   TestAccCloudflareZone_NameLookup
=== PAUSE TestAccCloudflareZone_NameLookup
=== RUN   TestAccCloudflareZone_Basic
--- PASS: TestAccCloudflareZone_Basic (11.37s)
=== RUN   TestAccCloudflareZone_BasicWithJumpStartEnabled
--- PASS: TestAccCloudflareZone_BasicWithJumpStartEnabled (11.55s)
=== RUN   TestAccCloudflareZone_WithPlan
--- PASS: TestAccCloudflareZone_WithPlan (12.29s)
=== RUN   TestAccCloudflareZone_PartialSetup
--- PASS: TestAccCloudflareZone_PartialSetup (11.87s)
=== RUN   TestAccCloudflareZone_FullSetup
--- PASS: TestAccCloudflareZone_FullSetup (12.69s)
=== RUN   TestAccCloudflareZone_WithEnterprisePlan
--- PASS: TestAccCloudflareZone_WithEnterprisePlan (16.94s)
=== RUN   TestAccCloudflareZone_SetType
--- PASS: TestAccCloudflareZone_SetType (24.60s)
=== CONT  TestAccCloudflareZone_PreventZoneIdAndNameConflicts
--- PASS: TestAccCloudflareZone_PreventZoneIdAndNameConflicts (2.74s)
=== CONT  TestAccCloudflareZone_NameLookup
--- PASS: TestAccCloudflareZone_NameLookup (10.68s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/cloudflare	115.014s
?   	github.com/cloudflare/terraform-provider-cloudflare/version	[no test files]

@jacobbednarz jacobbednarz merged commit 2890354 into master Nov 5, 2021
@jacobbednarz jacobbednarz deleted the allow-setting-zone-type branch November 5, 2021 03:57
github-actions bot pushed a commit that referenced this pull request Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes to zone type are ignored
1 participant