Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cloudflare_access_identity_provider datasource #1300

Merged
merged 4 commits into from
Nov 26, 2021
Merged

Add cloudflare_access_identity_provider datasource #1300

merged 4 commits into from
Nov 26, 2021

Conversation

cucxabong
Copy link
Contributor

Fix #1225
This is my very first MR, if anything need to be done, please advising. Thank you

jacobbednarz
jacobbednarz reviewed Nov 5, 2021
View reviewed changes
website/cloudflare.erb Outdated Show resolved Hide resolved
jacobbednarz
jacobbednarz reviewed Nov 5, 2021
View reviewed changes
cloudflare/provider.go Outdated Show resolved Hide resolved
@jacobbednarz jacobbednarz added kind/new-data-source Categorizes issue or PR as related to needing to create a datasource. service/access Categorizes issue or PR as related to the Access service. labels Nov 5, 2021
jacobbednarz
jacobbednarz reviewed Nov 5, 2021
View reviewed changes
Copy link
Member

@jacobbednarz jacobbednarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i've pushed up some nitpicky fixes so the last thing outstanding is adding a CHANGELOG entry (see notes at changelog-process.md) and we can get this merged

this is a solid PR, thanks for it! 🥇

@cucxabong
Copy link
Contributor Author

Thank you very much for your feedback. I have added change log for this MR, please help to take a look

@github-actions
Copy link
Contributor

Marking this pull request as stale due to 14 days of inactivity. This helps our maintainers find and focus on the active pull requests. If this pull request receives no comments in the next 7 days it will automatically be closed. Maintainers can also remove the lifecycle/stale label.
If this pull request was automatically closed and you feel this pull request should be reopened, we encourage creating a new pull request linking back to this one for added context. Thank you!

@cucxabong
Copy link
Contributor Author

up to avoid stale

@jacobbednarz
Copy link
Member

sorry for the delay, would you mind updating this PR to match the conventions in #1321 (with the schema in a dedicated file). after that, we're good to merge here.

@cucxabong
Copy link
Contributor Author

updated, please take a look

@jacobbednarz jacobbednarz merged commit f2c506d into cloudflare:master Nov 26, 2021
@jacobbednarz
Copy link
Member

thank you for your patience! 🎂

@cucxabong
Copy link
Contributor Author

thanks for your help & congrats to you & your family 🍼 👶

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobbednarz jacobbednarz jacobbednarz left review comments

Assignees
No one assigned
Labels
kind/new-data-source Categorizes issue or PR as related to needing to create a datasource. service/access Categorizes issue or PR as related to the Access service.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add cloudflare_access_identity_provider data source
2 participants
@cucxabong @jacobbednarz