Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set values to role ID's in resourceCloudflareAccountMemberRead #1202

Merged
merged 10 commits into from
Sep 22, 2021
Merged

set values to role ID's in resourceCloudflareAccountMemberRead #1202

merged 10 commits into from
Sep 22, 2021

Conversation

shubhambjadhavar
Copy link
Contributor

Cloudflare provider is not able to give diff for the changes made via UI in role ID's. Fixing it by setting values to role ids in resourceCloudflareAccountMemberRead.

@jacobbednarz
Copy link
Member

thanks for raising this PR! 🍰 before we land this, we need a couple of things:

  • CI to be all green
  • added test coverage for this change
  • a CHANGELOG entry (details on how to do this can be found at in changelog process)

@jacobbednarz jacobbednarz added kind/enhancement Categorizes issue or PR as related to improving an existing feature. workflow/pending-contributor-response Indicates an issue or PR requires a response from a contributor. labels Sep 16, 2021
@shubhambjadhavar
Copy link
Contributor Author

shubhambjadhavar commented Sep 17, 2021

Hi @jacobbednarz, is there any extra work needed in this PR?

@jacobbednarz
Copy link
Member

yes, this is still missing test coverage for the change

.changelog/1202.txt Outdated Show resolved Hide resolved
@shubhambjadhavar
Copy link
Contributor Author

No file named resource_account_member_test. Where should I add test cases?

@jacobbednarz
Copy link
Member

jacobbednarz commented Sep 17, 2021 via email

@jacobbednarz
Copy link
Member

we're green with the acceptance tests

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./...) -v -run "^TestAccCloudflareAccountMemberBasic" -count 1 -parallel 1 -timeout 120m -parallel 1
?   	github.com/cloudflare/terraform-provider-cloudflare	[no test files]
=== RUN   TestAccCloudflareAccountMemberBasic
--- PASS: TestAccCloudflareAccountMemberBasic (10.15s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/cloudflare	10.648s
?   	github.com/cloudflare/terraform-provider-cloudflare/version	[no test files]

thank you for this work!

@jacobbednarz jacobbednarz merged commit 6f52ab6 into cloudflare:master Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Categorizes issue or PR as related to improving an existing feature. workflow/pending-contributor-response Indicates an issue or PR requires a response from a contributor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants