-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set values to role ID's in resourceCloudflareAccountMemberRead #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thanks for raising this PR! 🍰 before we land this, we need a couple of things:
|
jacobbednarz
added
kind/enhancement
Categorizes issue or PR as related to improving an existing feature.
workflow/pending-contributor-response
Indicates an issue or PR requires a response from a contributor.
labels
Sep 16, 2021
Hi @jacobbednarz, is there any extra work needed in this PR? |
yes, this is still missing test coverage for the change |
No file named resource_account_member_test. Where should I add test cases? |
create one :) there are plenty of examples in the repository to use as
starting points.
|
we're green with the acceptance tests
thank you for this work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind/enhancement
Categorizes issue or PR as related to improving an existing feature.
workflow/pending-contributor-response
Indicates an issue or PR requires a response from a contributor.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cloudflare provider is not able to give diff for the changes made via UI in role ID's. Fixing it by setting values to role ids in resourceCloudflareAccountMemberRead.