Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mike/gate 1848 terraform support teams rules accounts #1173

Merged
merged 3 commits into from
Sep 5, 2021
Merged

Mike/gate 1848 terraform support teams rules accounts #1173

merged 3 commits into from
Sep 5, 2021

Conversation

Michael9127
Copy link
Contributor

@Michael9127 Michael9127 commented Aug 31, 2021 •
edited
Loading

Adds support for Cloudflare Teams Gateway account and rule configuration.

@Michael9127 Michael9127 force-pushed the mike/GATE-1848-terraform-support-teams-rules-accounts branch from bf16ff0 to 7129a28 Compare August 31, 2021 17:28
jacobbednarz
jacobbednarz requested changes Sep 1, 2021
View reviewed changes
Copy link
Member

@jacobbednarz jacobbednarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small nitpicks on method naming for consistency but other than that, looks awesome!

cloudflare/provider.go Outdated Show resolved Hide resolved
cloudflare/resource_cloudflare_teams_accounts.go Outdated Show resolved Hide resolved
cloudflare/resource_cloudflare_teams_accounts_test.go Outdated Show resolved Hide resolved
cloudflare/resource_cloudflare_teams_accounts_test.go Outdated Show resolved Hide resolved
cloudflare/resource_cloudflare_teams_rules.go Show resolved Hide resolved
cloudflare/resource_cloudflare_teams_accounts.go Outdated Show resolved Hide resolved
cloudflare/resource_cloudflare_teams_accounts.go Outdated Show resolved Hide resolved
cloudflare/resource_cloudflare_teams_accounts.go Outdated Show resolved Hide resolved
cloudflare/resource_cloudflare_teams_accounts_test.go Show resolved Hide resolved
cloudflare/resource_cloudflare_teams_rules.go Show resolved Hide resolved
@Michael9127 Michael9127 force-pushed the mike/GATE-1848-terraform-support-teams-rules-accounts branch from 7129a28 to acd87ee Compare September 2, 2021 14:57
@jacobbednarz
Copy link
Member

just needing the registry documentation here and we can merge! see a good example in #1113

@Michael9127 Michael9127 force-pushed the mike/GATE-1848-terraform-support-teams-rules-accounts branch from acd87ee to 82ef5bd Compare September 3, 2021 15:20
@Michael9127
Copy link
Contributor Author

Updated documentation for this PR and my previous one for Teams Locations where I forgot to.

@jacobbednarz
Copy link
Member

i pushed up some fixes for the documentation and Import functionality but this looks great! integration is all green too.

TF_ACC=1 go test $(go list ./...) -v -run "^(TestAccCloudflareTeamsAccountConfigurationBasic|TestAccCloudflareTeamsRuleBasic)" -count 1 -timeout 120m -parallel 1
?   	github.com/cloudflare/terraform-provider-cloudflare	[no test files]
=== RUN   TestAccCloudflareTeamsAccountConfigurationBasic
--- PASS: TestAccCloudflareTeamsAccountConfigurationBasic (1.75s)
=== RUN   TestAccCloudflareTeamsRuleBasic
--- PASS: TestAccCloudflareTeamsRuleBasic (2.79s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/cloudflare	5.192s
?   	github.com/cloudflare/terraform-provider-cloudflare/version	[no test files]

@jacobbednarz jacobbednarz merged commit 3afeb47 into cloudflare:master Sep 5, 2021
jacobbednarz added a commit that referenced this pull request Sep 14, 2021
@jacobbednarz
release notes for #1173
2cc605a
jacobbednarz added a commit that referenced this pull request Sep 14, 2021
@jacobbednarz
release notes for #1173 (#1193)
3a87408
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobbednarz jacobbednarz Awaiting requested review from jacobbednarz jacobbednarz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Michael9127 @jacobbednarz