-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New data source - cloudflare_origin_ca_root_certificate
#1158
New data source - cloudflare_origin_ca_root_certificate
#1158
Conversation
some minor nitpicks but nothing major 👍 once we get those sorted, this looks fine to merge in. |
integration tests look good
|
Co-authored-by: Jacob Bednarz <[email protected]>
Co-authored-by: Jacob Bednarz <[email protected]>
Co-authored-by: Jacob Bednarz <[email protected]>
Co-authored-by: Jacob Bednarz <[email protected]>
Thanks for the review. Accepted all suggestions. Hope you don't mind me tagging an extra commit on to the PR - I took the liberty of fixing the |
0b01bbe
to
eb26e80
Compare
eb26e80
to
7eddf58
Compare
Hi @jacobbednarz, Just checking in on this PR to make sure it hasn't dropped off your radar. Let me know if there's anything else you need me to do. Cheers. |
this definitely hasn't fallen off my radar; just a little swamped this
week coming back from vacation :)
will hopefully wrap this up this week at some point.
|
🥳 thanks for this! |
|
Yeah, unfortunately Cloudflare adjusted the URLs that were being used to retrieve the certs. This has been fixed in cloudflare/cloudflare-go#819 but we'll need to wait for a new release of that library to be able to fix this one. |
Introduces new data source
cloudflare_origin_ca_root_certificate
which can be used to read the Origin CA root certificate for a given algorithm.Closes #1096