Implement waiting room resource

[bpaquet]

Need cloudflare/cloudflare-go#627 to be merged and released before.

[jacobbednarz]

this functionality should be pulled into the Read method

[bpaquet]

Done

[jacobbednarz]

thanks for the updates here; it looks like we're almost there but still missing tests for this new functionality. are you able to add those to ensure this functionality works as intended and we can catch any regressions going forward?

[bpaquet]

thanks for the updates here; it looks like we're almost there but still missing tests for this new functionality. are you able to add those to ensure this functionality works as intended and we can catch any regressions going forward?

Do you mean unit test or acceptance test? I did not find a lot of unit test. And I'm not sure how acceptance test works. Do you have a doc around them?

[jacobbednarz]

integration tests for the actual resources. see the README (https://github.com/cloudflare/terraform-provider-cloudflare#developing-the-provider) and Terraform's own documentation for acceptance testing https://www.terraform.io/docs/extend/testing/acceptance-tests/index.html

[jacobbednarz]

@bpaquet are you still interested in completing this one?

[bpaquet]

Yes, but I cannt write acceptance test, I need a dedicated Cloudflare account for this. Bertrand

…

On Mon, Jun 21, 2021 at 2:56 AM Jacob Bednarz ***@***.***> wrote: @bpaquet <https://github.com/bpaquet> are you still interested in completing this one? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1053 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACSJXITALOE65KQZWSH6WLTT2E4JANCNFSM44LC5ZUQ> .

[jacobbednarz]

If you create a free zone, email me (or Cloudflare Support) the zone ID and I can take a look at adding the entitlements temporarily for you to add this.

[jacobbednarz]

Nice, we're all green on the acceptance testing accounts too so this is good to merge.

TF_ACC=1 go test $(go list ./...) -v -run "^TestAccCloudflareWaitingRoom_" -timeout 120m -parallel 1
?   	github.com/cloudflare/terraform-provider-cloudflare	[no test files]
=== RUN   TestAccCloudflareWaitingRoom_Create
=== PAUSE TestAccCloudflareWaitingRoom_Create
=== CONT  TestAccCloudflareWaitingRoom_Create
--- PASS: TestAccCloudflareWaitingRoom_Create (2.59s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/cloudflare	3.231s
?   	github.com/cloudflare/terraform-provider-cloudflare/version	[no test files]