logpush_job: make ownership_challenge optional #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks @taurelius! this looks great and i appreciate your effort here 👏 |
|
No worries @jacobbednarz! If possible it'd be great to get the API docs updated too. Happy to PR if there's a public repo for them, though haven't been able to find one 🤔 |
|
afraid that's internal but i can pass it onto the team to rectify. |
|
just looping back on this one; the team was making doc changes at the same time so i lumped in this change. it is now reflecting the resource expectation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes
ownership_challengeargument optional when thedestination_confis Datadog, Splunk or S3-Compatible (non-AWS).closes #1010