Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logpush_job: update docs to explicitly mention identical destination_conf values #1024

Merged
merged 1 commit into from
Apr 11, 2021
Merged

logpush_job: update docs to explicitly mention identical destination_conf values #1024

merged 1 commit into from
Apr 11, 2021

Conversation

jacobbednarz
Copy link
Member

@jacobbednarz jacobbednarz commented Apr 11, 2021 •
edited
Loading

Make it explicit that if we're attempting to do the automated approach, all the references to
destination_conf must be identical otherwise it will fail.

Closes #1019

@jacobbednarz jacobbednarz mentioned this pull request Apr 11, 2021
Closed
@jacobbednarz jacobbednarz merged commit aea20c3 into master Apr 11, 2021
@jacobbednarz jacobbednarz deleted the add-docs-for-identical-destination-conf branch April 11, 2021 23:45
simpsora
simpsora approved these changes Apr 11, 2021
View reviewed changes
Copy link
Contributor

@simpsora simpsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , thanks!

@dmuse89 dmuse89 mentioned this pull request May 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simpsora simpsora simpsora approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automated Logpush challenge not working
2 participants
@jacobbednarz @simpsora