Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct access_application terraform import docs #1002

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

tjefferson08
Copy link
Contributor

The correct import key is the composite of account ID (not zone ID) and application ID

source for import

@jacobbednarz
Copy link
Member

Thanks for this @tjefferson08. We can ignore the tfproviderlint failures here as it is unrelated to the documentation change.

Worth noting this fixes the documentation however the Import itself is still broken due to not supporting the Account and Zone level Access applications which we'll likely need to fix in another PR.

@jacobbednarz jacobbednarz merged commit 39e4ebb into cloudflare:master Mar 24, 2021
@tjefferson08
Copy link
Contributor Author

Happy to help!

Worth noting this fixes the documentation however the Import itself is still broken due to not supporting the Account and Zone level Access applications which we'll likely need to fix in another PR.

@jacobbednarz as I recall, I was able to import once I swapped in the account ID (after peeking at the source)

But you're saying you need to support import by zone ID?

@jacobbednarz
Copy link
Member

Correct. Access resources are currently available for both zone + accounts however the access_application import doesn't support that. I've fixed this for access_policy via #956 in the past.

@waynejnicklin
Copy link

So it seems that the documentation still says that only account id import is supported, not zone id?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants