From 7f3cd670248ca22b1015c2d8ab161e07f36edf2b Mon Sep 17 00:00:00 2001 From: Jacob Bednarz Date: Thu, 26 Dec 2024 13:03:14 +1100 Subject: [PATCH] resource/cloudflare_teams_location: remove unusable `policy_ids` This field was removed from the product and API long ago and no longer does anything. It should have been deprecated long ago. Seeing how it's no longer usable, remove it from the schema to prevent confusion. --- .changelog/4817.txt | 3 +++ docs/resources/teams_location.md | 1 - docs/resources/zero_trust_dns_location.md | 1 - internal/sdkv2provider/resource_cloudflare_teams_location.go | 3 --- internal/sdkv2provider/schema_cloudflare_teams_location.go | 5 ----- 5 files changed, 3 insertions(+), 10 deletions(-) create mode 100644 .changelog/4817.txt diff --git a/.changelog/4817.txt b/.changelog/4817.txt new file mode 100644 index 0000000000..1405728ab7 --- /dev/null +++ b/.changelog/4817.txt @@ -0,0 +1,3 @@ +```release-note:note +resource/cloudflare_teams_location: remove unusable `policy_ids` attribute +``` diff --git a/docs/resources/teams_location.md b/docs/resources/teams_location.md index 7574ed4e25..fa7cf986c2 100644 --- a/docs/resources/teams_location.md +++ b/docs/resources/teams_location.md @@ -50,7 +50,6 @@ resource "cloudflare_teams_location" "example" { - `id` (String) The ID of this resource. - `ip` (String) Client IP address. - `ipv4_destination` (String) IP to direct all IPv4 DNS queries to. -- `policy_ids` (List of String) ### Nested Schema for `networks` diff --git a/docs/resources/zero_trust_dns_location.md b/docs/resources/zero_trust_dns_location.md index 7d8d806280..1b71ebc83b 100644 --- a/docs/resources/zero_trust_dns_location.md +++ b/docs/resources/zero_trust_dns_location.md @@ -50,7 +50,6 @@ resource "cloudflare_zero_trust_dns_location" "example" { - `id` (String) The ID of this resource. - `ip` (String) Client IP address. - `ipv4_destination` (String) IP to direct all IPv4 DNS queries to. -- `policy_ids` (List of String) ### Nested Schema for `networks` diff --git a/internal/sdkv2provider/resource_cloudflare_teams_location.go b/internal/sdkv2provider/resource_cloudflare_teams_location.go index 8fdb131eb1..1ca7fdef4c 100644 --- a/internal/sdkv2provider/resource_cloudflare_teams_location.go +++ b/internal/sdkv2provider/resource_cloudflare_teams_location.go @@ -68,9 +68,6 @@ func resourceCloudflareTeamsLocationRead(ctx context.Context, d *schema.Resource if err := d.Set("networks", flattenTeamsLocationNetworks(location.Networks)); err != nil { return diag.FromErr(fmt.Errorf("error parsing Location networks")) } - if err := d.Set("policy_ids", location.PolicyIDs); err != nil { - return diag.FromErr(fmt.Errorf("error parsing Location policy IDs")) - } if err := d.Set("ip", location.Ip); err != nil { return diag.FromErr(fmt.Errorf("error parsing Location IP")) } diff --git a/internal/sdkv2provider/schema_cloudflare_teams_location.go b/internal/sdkv2provider/schema_cloudflare_teams_location.go index 2d24e4cdf9..08334f0abf 100644 --- a/internal/sdkv2provider/schema_cloudflare_teams_location.go +++ b/internal/sdkv2provider/schema_cloudflare_teams_location.go @@ -45,11 +45,6 @@ func resourceCloudflareTeamsLocationSchema() map[string]*schema.Schema { Optional: true, Description: "Indicator that this location needs to resolve EDNS queries.", }, - "policy_ids": { - Type: schema.TypeList, - Elem: &schema.Schema{Type: schema.TypeString}, - Computed: true, - }, "ip": { Type: schema.TypeString, Computed: true,