Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow import of node:* and cloudflare:* in worker custom entrypoint #898

Merged
merged 3 commits into from
Dec 8, 2024

Conversation

SamyPesse
Copy link
Contributor

This PR fixes an issue where when using a custom entrypoint, it's not possible to import node: or cloudflare: packages.

Copy link

changeset-bot bot commented Oct 26, 2024

🦋 Changeset detected

Latest commit: cbc346b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@cloudflare/next-on-pages Patch
eslint-plugin-next-on-pages Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@james-elicx james-elicx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a changeset as well please?

@SamyPesse SamyPesse requested a review from james-elicx October 28, 2024 14:41
Copy link
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch for the improvement @SamyPesse 😄

So sorry for the ultra late review 🙇

Copy link
Contributor

github-actions bot commented Dec 8, 2024

🧪 Prereleases are available for testing 🧪

@cloudflare/next-on-pages

You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/next-on-pages/runs/12221542272/npm-package-next-on-pages-898

@cloudflare/eslint-plugin-next-on-pages

You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/next-on-pages/runs/12221542272/npm-package-eslint-plugin-next-on-pages-898

@dario-piotrowicz dario-piotrowicz merged commit edd4fea into cloudflare:main Dec 8, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants