Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swap to stblib errors #972

Merged

Conversation

jacobbednarz
Copy link
Member

Updates error handling to use built in methods instead of external package.

  • use the errors import in favour of github.com/pkg/errors
  • errors.Wrap => errors.Errof("...: %w", err)
  • errors.Errorf => fmt.Errorf

Closes #968

@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2022

Codecov Report

Merging #972 (7c5d7f8) into master (44f0966) will decrease coverage by 0.06%.
The diff coverage is 4.67%.

@@            Coverage Diff             @@
##           master     #972      +/-   ##
==========================================
- Coverage   48.59%   48.53%   -0.07%     
==========================================
  Files          97       97              
  Lines        9940     9940              
==========================================
- Hits         4830     4824       -6     
- Misses       4049     4055       +6     
  Partials     1061     1061              
Impacted Files Coverage Δ
access_audit_log.go 79.31% <0.00%> (ø)
access_ca_certificate.go 71.23% <0.00%> (ø)
access_identity_provider.go 70.00% <0.00%> (ø)
access_keys.go 71.42% <0.00%> (ø)
access_mutual_tls_certificates.go 72.22% <0.00%> (ø)
access_organization.go 64.70% <0.00%> (ø)
access_service_tokens.go 68.42% <0.00%> (ø)
account_roles.go 53.84% <0.00%> (ø)
accounts.go 50.81% <0.00%> (ø)
api_token.go 42.52% <0.00%> (ø)
... and 78 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44f0966...7c5d7f8. Read the comment docs.

Updates error handling to use built in methods instead of external package.

- use the `errors` import in favour of `github.com/pkg/errors`
- `errors.Wrap` => `errors.Errof("...: %w", err)`
- `errors.Errorf` => `fmt.Errorf`

Closes cloudflare#968
@jacobbednarz jacobbednarz merged commit aaf5046 into cloudflare:master Jul 4, 2022
@jacobbednarz jacobbednarz deleted the errors-to-stdlib-errors branch July 4, 2022 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace github.com/pkg/error with native error wrapping
2 participants