Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add flag to skip the app launcher landing pg #2793

Merged
merged 2 commits into from
Jul 31, 2024
Merged

feat: add flag to skip the app launcher landing pg #2793

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec51561
feat: add flag to skip the app launcher landing pg
sha-e-256 Jul 29, 2024
369a946
Update .changelog/2793.txt
jacobbednarz Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/2793.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:enhancement
resource/access_application: add `skip_app_launcher_login_page` flag to skip the App Launcher landing page
```
11 changes: 6 additions & 5 deletions access_application.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,11 +250,12 @@ type SaasApplication struct {
}

type AccessAppLauncherCustomization struct {
LandingPageDesign AccessLandingPageDesign `json:"landing_page_design"`
LogoURL string `json:"app_launcher_logo_url"`
HeaderBackgroundColor string `json:"header_bg_color"`
BackgroundColor string `json:"bg_color"`
FooterLinks []AccessFooterLink `json:"footer_links"`
LandingPageDesign AccessLandingPageDesign `json:"landing_page_design"`
LogoURL string `json:"app_launcher_logo_url"`
HeaderBackgroundColor string `json:"header_bg_color"`
BackgroundColor string `json:"bg_color"`
FooterLinks []AccessFooterLink `json:"footer_links"`
SkipAppLauncherLoginPage *bool `json:"skip_app_launcher_login_page,omitempty"`
}

type AccessFooterLink struct {
Expand Down
5 changes: 4 additions & 1 deletion access_application_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1292,7 +1292,8 @@ func TestCreateApplicationWithAccessAppLauncherCustomization(t *testing.T) {
"url": "https://somesite.com",
"name": "bug"
}
]
],
"skip_app_launcher_login_page": true
}
}
`)
Expand Down Expand Up @@ -1332,6 +1333,7 @@ func TestCreateApplicationWithAccessAppLauncherCustomization(t *testing.T) {
Name: "bug",
},
},
SkipAppLauncherLoginPage: BoolPtr(true),
},
}

Expand All @@ -1357,6 +1359,7 @@ func TestCreateApplicationWithAccessAppLauncherCustomization(t *testing.T) {
Name: "bug",
},
},
SkipAppLauncherLoginPage: BoolPtr(true),
},
})

Expand Down