Add support for Get/Update API Shield Operation Schema Validation settings #1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
changelog detected ✅ |
djhworld
changed the title
api_shield_schemas.go
Outdated
| // UpdateAPIShieldOperationSchemaValidationSettings updates operation level schema validation settings | ||
| // | ||
| // API documentation: https://developers.cloudflare.com/api/operations/api-shield-schema-validation-update-operation-level-settings | ||
| func (api *API) UpdateAPIShieldOperationSchemaValidationSettings(ctx context.Context, rc *ResourceContainer, params UpdateAPIShieldOperationSchemaValidationSettingsParams) (*APIShieldOperationSchemaValidationSettings, error) { |
There was a problem hiding this comment.
similar to my comment in #1418 (comment), do we need both of these update methods? or could we use the one that accepts multiple updates for both?
There was a problem hiding this comment.
makes sense, have updated to remove the single one in favour of the multiple one (and renamed it to just be UpdateAPIShieldOperationSchemaValidationSettings)
- updated commit message + PR description https://github.com/cloudflare/cloudflare-go/compare/5f0ca009b6e91ec8bfe8b6213302ae7a6b51ca90..16c2b886cd034296d32039dea93997000f51ddb5
…lidation Settings Adds support for the following endpoints - Retrieve operation level schema validation settings - Update multiple operation level schema validation settings
|
This functionality has been released in v0.80.0. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the following endpoints
Description
Has your change been tested?
Screenshots (if appropriate):
Types of changes
What sort of change does your code introduce/modify?
Checklist:
and relies on stable APIs.