Add support for Get/Update API Shield Schema Validation Settings #1418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
changelog detected ✅ |
djhworld
force-pushed
the
dharper/APISHI-2361
branch
from
ce2b27f
to
0d0a92a
Compare
api_shield_schemas.go
Outdated
| // UpdateAllAPIShieldSchemaValidationSettings updates zone level schema validation settings | ||
| // | ||
| // API documentation: https://developers.cloudflare.com/api/operations/api-shield-schema-validation-update-zone-level-settings | ||
| func (api *API) UpdateAllAPIShieldSchemaValidationSettings(ctx context.Context, rc *ResourceContainer, params UpdateAllAPIShieldSchemaValidationSettingsParams) (*APIShieldSchemaValidationSettings, error) { |
There was a problem hiding this comment.
the way we would generally handle this is that we wouldn't include this method if the individual fields update endpoint was available (such as UpdateAPIShieldSchemaValidationSettings). we would opt to instead use the one method to update a single or all of the fields. does that make sense to do in this context?
There was a problem hiding this comment.
Makes sense! Have removed this in favour of the PATCH endpoint.
…ettings This change adds support for the following API Shield related endpoints related to API Shield Schema Validation Settings: - Retrieve API Shield Schema Validation Settings - Update All API Shield Schema Validation Settings - Update API Shield Schema Validation Settings
djhworld
force-pushed
the
dharper/APISHI-2361
branch
from
0d0a92a
to
c52383a
Compare
|
wicked effort! thanks @djhworld 👏 |
|
This functionality has been released in v0.80.0. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for the following API Shield related endpoints related to API Shield Schema Validation Settings:
Description
Has your change been tested?
Screenshots (if appropriate):
Types of changes
What sort of change does your code introduce/modify?
Checklist:
and relies on stable APIs.