Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dns: update ListDNSRecords default per_page attribute to 100 records #1171

Merged
merged 6 commits into from
Jan 10, 2023
Merged

dns: update ListDNSRecords default per_page attribute to 100 records #1171

merged 6 commits into from
Jan 10, 2023

Commits on Jan 9, 2023

  1. Match ListDNSRecords per_page value to the API's 

    As outlined in github.com/cloudflare/pull/1169,
when no pagination options are passed in to ListDNSRecords,
autopagination is performed. However, the current PerPage
value doesn't match that of the official API. This commit
makes both values match. A new test is also implemented that
more explicitly tests the auto pagination behaviour.

Signed-off-by: Artur Rodrigues <[email protected]>
    @arturhoo
    Artur Rodrigues authored and arturhoo committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    f0f163b View commit details
    Browse the repository at this point in the history

  2. Add changelog entry 

    Signed-off-by: Artur Rodrigues <[email protected]>
    @arturhoo
    Artur Rodrigues authored and arturhoo committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    ff35c3c View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2023

  1. comments cleanup

    @jacobbednarz
    jacobbednarz authored Jan 10, 2023
    Configuration menu
    Copy the full SHA
    99374ea View commit details
    Browse the repository at this point in the history

  2. dns_test: default case for unexpected pages 

    As per @favonia suggestion
    @arturhoo
    arturhoo committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    cf51b38 View commit details
    Browse the repository at this point in the history

  3. Got fmt

    @arturhoo
    arturhoo committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    40468f7 View commit details
    Browse the repository at this point in the history

  4. dns: Shorten docstring

    @arturhoo
    arturhoo committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    f59c0fc View commit details
    Browse the repository at this point in the history