Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: omit 'Priority=' in the query URL #1168

Closed
wants to merge 1 commit into from

Conversation

favonia
Copy link

@favonia favonia commented Jan 6, 2023

Description

Current, ListDNSRecords will generate an URL with Priority=. While it is mostly harmless, I prefer not to adjust my testing framework because of this, and here we are. The change follows the comment at a7b8640#r95126277.

Has your change been tested?

Yes, but using my own testing framework.

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

@favonia favonia requested a review from jacobbednarz as a code owner January 6, 2023 01:13
@github-actions
Copy link

github-actions bot commented Jan 6, 2023

Oops! It looks like no changelog entry is attached to this PR. Please include a release note as described in https://github.com/cloudflare/cloudflare-go/blob/master/docs/changelog-process.md.

Example:

```release-note:TYPE
Release note
```

If you do not require a release note to be included, please add the workflow/skip-changelog-entry label.

@favonia
Copy link
Author

favonia commented Jan 6, 2023

Already done in #1167. 😅

@favonia favonia closed this Jan 6, 2023
@favonia favonia deleted the no-Priority branch January 6, 2023 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant