-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for DNS record comments and tags #1158
Add support for DNS record comments and tags #1158
Conversation
Oops! It looks like no changelog entry is attached to this PR. Please include a release note as described in https://github.com/cloudflare/cloudflare-go/blob/master/docs/changelog-process.md. Example:
If you do not require a release note to be included, please add the |
Closing in favor of #1151 which looks good and has already been merged! |
@janik-cloudflare I have a question about the new DNS record comment API: How should I clear a comment or set the comment to empty without recreating the DNS record? |
Hi @favonia! Comments can be removed by setting them to |
@janik-cloudflare Thanks. I wonder if it's still possible the change the design to treat the empty string as clearing comment for the following reasons:
PS: I know |
@favonia I've discussed this with the team. We agree that the current solution isn't ideal (e.g., Golang makes it too difficult to distinguish between If a PATCH request with |
Description
This adds support for DNS record comment and tags.
Blog post: https://blog.cloudflare.com/dns-record-comments/
Documentation: https://developers.cloudflare.com/dns/manage-dns-records/reference/record-attributes/
Has your change been tested?
Updated unit tests.
Types of changes
What sort of change does your code introduce/modify?
Checklist: