Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GATE-5397: Add support for extended email matching setting #1486

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

dfialho
Copy link
Contributor

@dfialho dfialho commented Jan 26, 2024

Description

This change introduces support for enabling/disabling extended e-mail matching

Has your change been tested?

Tested manually and by adjusting unit tests

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

Copy link
Contributor

github-actions bot commented Jan 26, 2024

changelog detected ✅

Copy link
Member

@jacobbednarz jacobbednarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! ping me once you have those API docs and we can get this merged 🏆

@codecov-commenter
Copy link

Codecov Report

Attention: 538 lines in your changes are missing coverage. Please review.

Comparison is base (b9ac804) 48.33% compared to head (942c690) 53.59%.
Report is 591 commits behind head on master.

Files Patch % Lines
api_shield_schemas.go 54.81% 35 Missing and 26 partials ⚠️
observatory.go 54.68% 29 Missing and 29 partials ⚠️
per_hostname_tls_settings.go 41.86% 25 Missing and 25 partials ⚠️
dlp_dataset.go 45.45% 24 Missing and 24 partials ⚠️
logpush.go 48.86% 43 Missing and 2 partials ⚠️
devices_policy.go 56.96% 23 Missing and 11 partials ⚠️
access_users.go 76.84% 11 Missing and 11 partials ⚠️
d1.go 70.27% 11 Missing and 11 partials ⚠️
access_custom_page.go 58.33% 10 Missing and 10 partials ⚠️
page_shield_policies.go 60.86% 9 Missing and 9 partials ⚠️
... and 19 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1486      +/-   ##
==========================================
+ Coverage   48.33%   53.59%   +5.25%     
==========================================
  Files         133      156      +23     
  Lines       13023    11903    -1120     
==========================================
+ Hits         6295     6379      +84     
+ Misses       5201     3672    -1529     
- Partials     1527     1852     +325     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dfialho
Copy link
Contributor Author

dfialho commented Jan 29, 2024

lgtm! ping me once you have those API docs and we can get this merged 🏆

Documentation has been updated https://developers.cloudflare.com/api/operations/zero-trust-accounts-update-zero-trust-account-configuration

Copy link
Member

@jacobbednarz jacobbednarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome @dfialho, thanks!

@jacobbednarz jacobbednarz merged commit c59ee79 into cloudflare:master Jan 30, 2024
11 checks passed
@github-actions github-actions bot added this to the v0.87.0 milestone Jan 30, 2024
github-actions bot pushed a commit that referenced this pull request Jan 30, 2024
Copy link
Contributor

This functionality has been released in v0.87.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants