Adding Page Shield support #1459
Conversation
|
changelog detected ✅ |
|
@jacobbednarz do you think it is necessary to use ptr's for boolean values in this? How stringent do you want me to be with the linter issues? |
|
the semgrep rules are in place from past issues we've seen with usage (especially the terraform provider). i'm not sure why but semgrep should be pointing you at https://github.com/cloudflare/cloudflare-go/blob/master/docs/conventions.md#booleans which explains it a little more too. |
|
I noticed some other files that don't use it, that's why I ask. I will update and push another. Apologies for the repetitive nature. |
|
i've gone through and applied a few updates from https://github.com/cloudflare/cloudflare-go/blob/master/docs/conventions.md#methods to get this closer to the library conventions and make our future maintenance a bit easier :) |
Thank you! I just noticed. I don't do a lot of public contribution.. thanks for helping me out :-) |
page_shield_scripts.go
Outdated
| // | ||
| // API reference: https://developers.cloudflare.com/api/operations/page-shield-list-page-shield-scripts#Query-Parameters | ||
| type ListPageShieldScriptsParams struct { | ||
| Direction string `json:"direction"` |
There was a problem hiding this comment.
similar to the above on query parameters.
|
it looks like the force push has lost my intermediary commits to get the conventions and linter happy. |
aaanndd that's why they say don't do a force push... I have your changes in the PR checked out on my machine. Do you want me to close this PR and open a new one? |
😂 check out https://blog.developer.atlassian.com/force-with-lease/
do you just want to cherry-pick them onto this one? whatever is easiest for you to do. |
|
To be honest, I have not cherry-picked before. That might cause more issues. I suppose I could try it and then if I screw it up, I have a local tarball of the changes.. I could just try again :-D |
|
@jacobbednarz thanks for the help with this. Seriously, appreciate your patience. I royally screwed this up on the send. |
|
no worries! thanks for the contribution 🏅 |
|
This functionality has been released in v0.84.0. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Description
Added support for Page Shield based on developer docs.
Has your change been tested?
All changes have been tested with test suites. Also, have tested using a local driver application
Screenshots (if appropriate):
Types of changes
What sort of change does your code introduce/modify?
Checklist:
and relies on stable APIs.