Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add list item search & list item pagination page size #1409

Merged
merged 3 commits into from
Sep 26, 2023

Conversation

jesopo
Copy link
Contributor

@jesopo jesopo commented Sep 25, 2023

regards recent addition of two query parameters here https://developers.cloudflare.com/api/operations/lists-get-list-items#Query-Parameters

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2023

changelog detected ✅

list.go Outdated
var cursor string
var cursorQuery string

var query = url.Values{}
Copy link
Member

@jacobbednarz jacobbednarz Sep 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

within the library, we can use a combination of buildURI and struct tags to simplify the handling and building of URLs. seeing how there is a release planned for tomorrow, i pushed up these changes on your behalf in 1cad030 to get this ready for merging. do let me know if you have any questions!

@jacobbednarz jacobbednarz merged commit feebb8a into cloudflare:master Sep 26, 2023
11 checks passed
@github-actions github-actions bot added this to the v0.78.0 milestone Sep 26, 2023
github-actions bot pushed a commit that referenced this pull request Sep 26, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v0.78.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants