-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for tags to CreateWorkerParams #1368
add support for tags to CreateWorkerParams #1368
Conversation
changelog detected ✅ |
@@ -269,7 +296,7 @@ func (api *API) UploadWorker(ctx context.Context, rc *ResourceContainer, params | |||
err error | |||
) | |||
|
|||
if params.Module || params.Logpush != nil || params.Placement != nil || len(params.Bindings) > 0 || params.CompatibilityDate != "" || len(params.CompatibilityFlags) > 0 || params.TailConsumers != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report
@@ Coverage Diff @@
## master #1368 +/- ##
==========================================
+ Coverage 48.33% 48.58% +0.24%
==========================================
Files 133 136 +3
Lines 13023 13257 +234
==========================================
+ Hits 6295 6441 +146
- Misses 5201 5260 +59
- Partials 1527 1556 +29
|
Finally got a chance to confirm this is documented, and it looks like it already was 🥳 |
This functionality has been released in v0.75.0. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Description
Our API supports tagging scripts (primarily for Workers for Platforms, but they also work for non-WFP scripts), and
cloudflare-go
support for them has been requested.Has your change been tested?
Yes, in the unit tests, but no against the API. It's still using the same endpoints it was before, so at least it won't have the same bug my last PR did :)
Types of changes
What sort of change does your code introduce/modify?
Checklist:
and relies on stable APIs.