Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for tags to CreateWorkerParams #1368

Merged

Conversation

aaronlisman
Copy link
Contributor

Description

Our API supports tagging scripts (primarily for Workers for Platforms, but they also work for non-WFP scripts), and cloudflare-go support for them has been requested.

Has your change been tested?

Yes, in the unit tests, but no against the API. It's still using the same endpoints it was before, so at least it won't have the same bug my last PR did :)

Types of changes

What sort of change does your code introduce/modify?

  • [❌] Bug fix (non-breaking change which fixes an issue)
  • [✅] New feature (non-breaking change which adds functionality)
  • [❌] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [✅] My code follows the code style of this project.
  • [✅] My change requires a change to the documentation.
  • [❌] I have updated the documentation accordingly.
    • I will ensure this field is documented in our API schema after opening the PR.
  • [✅] I have added tests to cover my changes.
  • [✅] All new and existing tests passed.
  • [❌, ✅] This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

changelog detected ✅

@@ -269,7 +296,7 @@ func (api *API) UploadWorker(ctx context.Context, rc *ResourceContainer, params
err error
)

if params.Module || params.Logpush != nil || params.Placement != nil || len(params.Bindings) > 0 || params.CompatibilityDate != "" || len(params.CompatibilityFlags) > 0 || params.TailConsumers != nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov-commenter
Copy link

Codecov Report

Merging #1368 (4863561) into master (b9ac804) will increase coverage by 0.24%.
Report is 132 commits behind head on master.
The diff coverage is 56.51%.

@@            Coverage Diff             @@
##           master    #1368      +/-   ##
==========================================
+ Coverage   48.33%   48.58%   +0.24%     
==========================================
  Files         133      136       +3     
  Lines       13023    13257     +234     
==========================================
+ Hits         6295     6441     +146     
- Misses       5201     5260      +59     
- Partials     1527     1556      +29     
Files Changed Coverage Δ
access_application.go 72.72% <ø> (ø)
access_audit_log.go 79.31% <ø> (ø)
access_bookmark.go 72.44% <ø> (ø)
access_ca_certificate.go 68.00% <ø> (ø)
access_group.go 70.00% <ø> (ø)
access_identity_provider.go 66.32% <ø> (ø)
access_keys.go 71.42% <ø> (ø)
access_mutual_tls_certificates.go 68.86% <ø> (ø)
access_organization.go 53.84% <ø> (ø)
access_service_tokens.go 51.85% <ø> (ø)
... and 118 more

@jacobbednarz jacobbednarz merged commit 9e66410 into cloudflare:master Aug 10, 2023
11 checks passed
@github-actions github-actions bot added this to the v0.75.0 milestone Aug 10, 2023
github-actions bot pushed a commit that referenced this pull request Aug 10, 2023
@aaronlisman
Copy link
Contributor Author

Finally got a chance to confirm this is documented, and it looks like it already was 🥳

@github-actions
Copy link
Contributor

This functionality has been released in v0.75.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants