-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add per-hostname tls settings api and tests #1356
Merged
jacobbednarz
merged 4 commits into
cloudflare:master
from
vasilzhigilei:vasil/add-per-hostname-tls-settings
Aug 10, 2023
Merged
add per-hostname tls settings api and tests #1356
jacobbednarz
merged 4 commits into
cloudflare:master
from
vasilzhigilei:vasil/add-per-hostname-tls-settings
Aug 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changelog detected ✅ |
jacobbednarz
reviewed
Aug 4, 2023
jacobbednarz
reviewed
Aug 4, 2023
jacobbednarz
reviewed
Aug 4, 2023
jacobbednarz
reviewed
Aug 4, 2023
jacobbednarz
reviewed
Aug 4, 2023
… the rest of the tls settings due to unique response structure
Codecov Report
@@ Coverage Diff @@
## master #1356 +/- ##
==========================================
+ Coverage 48.33% 48.45% +0.11%
==========================================
Files 133 137 +4
Lines 13023 13368 +345
==========================================
+ Hits 6295 6477 +182
- Misses 5201 5310 +109
- Partials 1527 1581 +54
|
This functionality has been released in v0.75.0. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Per-Hostname TLS Settings is a new API where customers can set TLS settings on a per-hostname basis while not being coupled to any specific certificate. SSL/TLS team.
Has your change been tested?
Added unit tests.
Screenshots (if appropriate):
Types of changes
What sort of change does your code introduce/modify?
Checklist:
and relies on stable APIs.