-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web Analytics support #1348
Web Analytics support #1348
Conversation
|
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
- | Generic High Entropy Secret | 29bea61 | web_analytics_test.go | View secret |
- | Generic High Entropy Secret | ee8cb4b | web_analytics_test.go | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
changelog detected ✅ |
All of the tokens/ids are random and not from an actual account. |
7ce0a6c
to
1cd322e
Compare
yeah, ignore the GitGuardian stuff. it's really blunt at finding "issues". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple of minor style/convention changes but the majority looks good to me! you should also consider if you need to make the booleans all pointers - https://github.com/cloudflare/cloudflare-go/blob/master/docs/conventions.md#booleans
Codecov Report
@@ Coverage Diff @@
## master #1348 +/- ##
==========================================
+ Coverage 48.33% 48.35% +0.01%
==========================================
Files 133 139 +6
Lines 13023 13609 +586
==========================================
+ Hits 6295 6580 +285
- Misses 5201 5402 +201
- Partials 1527 1627 +100
|
dac6a02
to
5f3f756
Compare
thanks @broswen! |
This functionality has been released in v0.75.0. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Description
Add Web Analytics Support.
CC @cf-ypark
Has your change been tested?
Unit tests have been added that align with the documented API spec.
I have locally tested the changes with a personal zone.
Screenshots (if appropriate):
Types of changes
What sort of change does your code introduce/modify?
Checklist:
and relies on stable APIs.
Public API documentation is available: https://developers.cloudflare.com/api/operations/web-analytics-create-site