Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AUTH-5403 added access custom pages #1343

Merged
merged 3 commits into from
Aug 1, 2023

Conversation

russellkerns
Copy link
Contributor

@russellkerns russellkerns commented Jul 31, 2023

Description

This PR will add the ability to CRUD Access custom pages

Has your change been tested?

Via units tests

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 31, 2023

changelog detected ✅

access_custom_page.go Outdated Show resolved Hide resolved
return customPagesResponse.Result, nil
}

func (api *API) AccessCustomPage(ctx context.Context, rc *ResourceContainer, customPageID string) (AccessCustomPage, error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similar to List we should prefix this with Get to align with the experimental client conventions.

Suggested change
func (api *API) AccessCustomPage(ctx context.Context, rc *ResourceContainer, customPageID string) (AccessCustomPage, error) {
func (api *API) GetAccessCustomPage(ctx context.Context, rc *ResourceContainer, customPageID string) (AccessCustomPage, error) {

access_custom_page.go Outdated Show resolved Hide resolved
access_custom_page.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2023

Codecov Report

Merging #1343 (bcc4eb4) into master (b9ac804) will increase coverage by 0.15%.
Report is 79 commits behind head on master.
The diff coverage is 58.26%.

@@            Coverage Diff             @@
##           master    #1343      +/-   ##
==========================================
+ Coverage   48.33%   48.49%   +0.15%     
==========================================
  Files         133      135       +2     
  Lines       13023    13203     +180     
==========================================
+ Hits         6295     6403     +108     
- Misses       5201     5248      +47     
- Partials     1527     1552      +25     
Files Changed Coverage Δ
access_application.go 72.72% <ø> (ø)
access_organization.go 53.84% <ø> (ø)
device_posture_rule.go 61.80% <ø> (ø)
load_balancing.go 59.40% <ø> (ø)
teams_accounts.go 53.84% <ø> (ø)
regional_tiered_cache.go 43.75% <43.75%> (ø)
logpush.go 51.81% <46.15%> (-0.30%) ⬇️
images.go 44.70% <47.82%> (-0.12%) ⬇️
access_custom_page.go 48.27% <48.27%> (ø)
rulesets.go 30.03% <52.17%> (-4.61%) ⬇️
... and 6 more

@jacobbednarz jacobbednarz merged commit 64a2c9b into cloudflare:master Aug 1, 2023
@github-actions github-actions bot added this to the v0.74.0 milestone Aug 1, 2023
github-actions bot pushed a commit that referenced this pull request Aug 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

This functionality has been released in v0.74.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants