-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AUTH-5403 added access custom pages #1343
Conversation
changelog detected ✅ |
481008c
to
0cb20c0
Compare
0cb20c0
to
816fc65
Compare
access_custom_page.go
Outdated
return customPagesResponse.Result, nil | ||
} | ||
|
||
func (api *API) AccessCustomPage(ctx context.Context, rc *ResourceContainer, customPageID string) (AccessCustomPage, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
similar to List
we should prefix this with Get
to align with the experimental client conventions.
func (api *API) AccessCustomPage(ctx context.Context, rc *ResourceContainer, customPageID string) (AccessCustomPage, error) { | |
func (api *API) GetAccessCustomPage(ctx context.Context, rc *ResourceContainer, customPageID string) (AccessCustomPage, error) { |
Codecov Report
@@ Coverage Diff @@
## master #1343 +/- ##
==========================================
+ Coverage 48.33% 48.49% +0.15%
==========================================
Files 133 135 +2
Lines 13023 13203 +180
==========================================
+ Hits 6295 6403 +108
- Misses 5201 5248 +47
- Partials 1527 1552 +25
|
This functionality has been released in v0.74.0. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Description
This PR will add the ability to CRUD Access custom pages
Has your change been tested?
Via units tests
Screenshots (if appropriate):
Types of changes
What sort of change does your code introduce/modify?
Checklist:
and relies on stable APIs.