-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add image upload by url #1335
Add image upload by url #1335
Conversation
changelog detected ✅ |
thanks for the PR here, appreciate it! for me though, i would rather see |
No problem and for sure - I was actually in two minds about whether to have a combined signature! I’ll rework it today - thanks for looking. |
@jacobbednarz handled your feedback - mind taking another look when you get time? 🙏 |
Codecov Report
@@ Coverage Diff @@
## master #1335 +/- ##
==========================================
+ Coverage 48.33% 48.43% +0.09%
==========================================
Files 133 133
Lines 13023 13072 +49
==========================================
+ Hits 6295 6331 +36
- Misses 5201 5208 +7
- Partials 1527 1533 +6
|
thanks for this one! appreciate it 🙇 |
Thanks @jacobbednarz! Any idea when this might be released? |
you can view the policy at https://github.com/cloudflare/cloudflare-go/blob/master/docs/changelog-process.md |
This functionality has been released in v0.73.0. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Description
The Cloudflare image API provides the ability to upload an image via a url, rather than as bytes. e.g. you might want to copy the image from some bucket to Cloudflare without having to manage the data yourself. This PR adds that functionality, heavily based on the existing file upload methodology.
Has your change been tested?
Added test in the same fashion as the file based upload method.
Types of changes
What sort of change does your code introduce/modify?
Checklist:
and relies on stable APIs.