Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds method to create image v2 direct upload url #1322

Merged
merged 10 commits into from
Jun 30, 2023

Conversation

jacobbednarz
Copy link
Member

This PR implements the missing feature to support images/v2/direct_upload
endpoint that lets client create direct upload url. The v2 version supports
metadata and requireSignedURLs as additional request parameters.

Closes #1248
Supersedes #1308

@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2023

changelog detected ✅

@codecov-commenter
Copy link

Codecov Report

Merging #1322 (768c9b2) into master (74e0b34) will decrease coverage by 0.68%.
The diff coverage is 68.05%.

@@            Coverage Diff             @@
##           master    #1322      +/-   ##
==========================================
- Coverage   48.95%   48.27%   -0.68%     
==========================================
  Files         135      133       -2     
  Lines       13180    13000     -180     
==========================================
- Hits         6452     6276     -176     
+ Misses       5212     5197      -15     
- Partials     1516     1527      +11     
Impacted Files Coverage Δ
access_audit_log.go 79.31% <0.00%> (ø)
device_posture_rule.go 61.80% <ø> (ø)
options.go 61.01% <ø> (-3.05%) ⬇️
teams_devices.go 52.63% <ø> (ø)
dns_firewall.go 7.69% <10.00%> (-13.74%) ⬇️
images.go 44.81% <46.06%> (-5.54%) ⬇️
tunnel.go 42.41% <66.66%> (+1.01%) ⬆️
access_policy.go 70.27% <73.33%> (-6.05%) ⬇️
access_application.go 72.72% <75.47%> (-3.80%) ⬇️
access_mutual_tls_certificates.go 68.86% <75.51%> (-3.36%) ⬇️
... and 9 more

... and 1 file with indirect coverage changes

@jacobbednarz jacobbednarz merged commit b4b8ba9 into master Jun 30, 2023
@jacobbednarz jacobbednarz deleted the feature/images-v2-direct-upload branch June 30, 2023 03:47
@github-actions github-actions bot added this to the v0.71.0 milestone Jun 30, 2023
github-actions bot pushed a commit that referenced this pull request Jun 30, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

This functionality has been released in v0.71.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image direct upload V2
3 participants