-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds method to create image v2 direct upload url #1322
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we don't really want this concept more broadly so let's limit the exposure of it
9 tasks
changelog detected ✅ |
Codecov Report
@@ Coverage Diff @@
## master #1322 +/- ##
==========================================
- Coverage 48.95% 48.27% -0.68%
==========================================
Files 135 133 -2
Lines 13180 13000 -180
==========================================
- Hits 6452 6276 -176
+ Misses 5212 5197 -15
- Partials 1516 1527 +11
|
This functionality has been released in v0.71.0. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the missing feature to support
images/v2/direct_upload
endpoint that lets client create direct upload url. The v2 version supports
metadata and requireSignedURLs as additional request parameters.
Closes #1248
Supersedes #1308