-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(workers): configure tail consumers #1317
feat(workers): configure tail consumers #1317
Conversation
changelog detected ✅ |
Codecov Report
@@ Coverage Diff @@
## master #1317 +/- ##
==========================================
- Coverage 48.95% 48.76% -0.19%
==========================================
Files 135 133 -2
Lines 13180 12989 -191
==========================================
- Hits 6452 6334 -118
+ Misses 5212 5149 -63
+ Partials 1516 1506 -10
|
thanks for the PR! ❤️ it. could of minor things i've fixed that we already had available in the library but no biggie.
i've avoided this sort of setup in the past as it gets hard to read and the output isn't explicit as to what we are testing but i'm happy to give it a whirl and see how this experiment pans out given the repetition we have in these tests. |
This functionality has been released in v0.71.0. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Hello from the Workers team 👋
Description
This adds the necessary functionality to the sdk to allow customers to set Tail Workers as consumers on their scripts. Tail Consumers are also included in the response metadata, and the updates the response to reflect that.
Additionally, this does a fairly large refactor to the Workers test suite, moving script response to a variadic parameters setup. Many of the existing hardcoded responses were out of date or half complete, so this ensures an easy way to make changes in 1 spot going forward for consistent & up to date api shapes.
For reviewing purposes these have been broken into separate commits.
Has your change been tested?
A test has been added to cover uploading a Tail Consumer.
Screenshots (if appropriate):
Types of changes
What sort of change does your code introduce/modify?
Checklist:
and relies on stable APIs.