-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add account level custom nameservers #1304
Merged
jacobbednarz
merged 9 commits into
cloudflare:master
from
rwhelan:acct_lvl_custom_nameservers
Jun 14, 2023
Merged
feat: add account level custom nameservers #1304
jacobbednarz
merged 9 commits into
cloudflare:master
from
rwhelan:acct_lvl_custom_nameservers
Jun 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changelog detected ✅ |
Codecov Report
@@ Coverage Diff @@
## master #1304 +/- ##
==========================================
- Coverage 49.07% 49.03% -0.04%
==========================================
Files 134 135 +1
Lines 13090 13165 +75
==========================================
+ Hits 6424 6456 +32
- Misses 5162 5197 +35
- Partials 1504 1512 +8
|
Instead, rely on `ResourceContainer` to build the endpoints.
thanks for the PR here @rwhelan 👋 |
This functionality has been released in v0.70.0. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for the APIs documented:
https://developers.cloudflare.com/api/operations/account-level-custom-nameservers-list-account-custom-nameservers
https://developers.cloudflare.com/api/operations/account-level-custom-nameservers-add-account-custom-nameserver
https://developers.cloudflare.com/api/operations/account-level-custom-nameservers-get-eligible-zones-for-account-custom-nameservers
https://developers.cloudflare.com/api/operations/account-level-custom-nameservers-verify-account-custom-nameserver-glue-records
https://developers.cloudflare.com/api/operations/account-level-custom-nameservers-delete-account-custom-nameserver
https://developers.cloudflare.com/api/operations/account-level-custom-nameservers-usage-for-a-zone-get-account-custom-nameserver-related-zone-metadata
https://developers.cloudflare.com/api/operations/account-level-custom-nameservers-usage-for-a-zone-set-account-custom-nameserver-related-zone-metadata
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Checklist:
and relies on stable APIs.
Closes #1299