tunnel: introduce custom Duration for time fields
#1303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobbednarz
force-pushed
the
refine-tunnel-duration
branch
from
7d8b62d to
9767bb7
Compare
|
cc @obezuk |
|
changelog detected ✅ |
jacobbednarz
force-pushed
the
refine-tunnel-duration
branch
from
9767bb7 to
81cb9bc
Compare
Codecov Report
@@ Coverage Diff @@
## master #1303 +/- ##
=======================================
Coverage 49.07% 49.08%
=======================================
Files 134 134
Lines 13090 13099 +9
=======================================
+ Hits 6424 6429 +5
- Misses 5162 5165 +3
- Partials 1504 1505 +1
|
Cyb3r-Jak3
reviewed
Jun 8, 2023
All Tunnel timeout values are based on seconds however, there isn't a great way to do this in a flexible way with Go due to `time.Duration` not having marshal/unmarshal support in Go 1[1]. Instead, we introduce a custom `TunnelDuration` value here and ensure it always converts durations into seconds without impacting other users of `time.Duration`. [1]: golang/go#10275
jacobbednarz
force-pushed
the
refine-tunnel-duration
branch
from
81cb9bc to
2aff559
Compare
|
This functionality has been released in v0.70.0. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Tunnel timeout values are based on seconds however, there isn't a great way to do this in a flexible way with Go due to
time.Durationnot having marshal/unmarshal support in Go 1. Instead, we introduce a customTunnelDurationvalue here and ensure it always converts durations into seconds without impacting other users oftime.Duration.This is similarly handled in cloudflared too.