Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

email_routing_destination: return err, not ErrMissingAccountID #1297

Merged
merged 1 commit into from
May 31, 2023

Conversation

jacobbednarz
Copy link
Member

Updates the error returned to be the correct API error, not the incorrect static one.

@github-actions
Copy link
Contributor

github-actions bot commented May 31, 2023

changelog detected ✅

Updates the error returned to be the correct API error, not the
incorrect static one.
@jacobbednarz jacobbednarz changed the title email_routing_desintation: return err, not ErrMissingAccountID email_routing_destination: return err, not ErrMissingAccountID May 31, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 31, 2023

Codecov Report

Merging #1297 (aebf178) into master (a5dc232) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1297      +/-   ##
==========================================
- Coverage   49.07%   49.07%   -0.01%     
==========================================
  Files         134      134              
  Lines       13091    13090       -1     
==========================================
- Hits         6425     6424       -1     
  Misses       5162     5162              
  Partials     1504     1504              
Impacted Files Coverage Δ
devices_policy.go 49.47% <ø> (ø)
dns.go 45.05% <ø> (ø)
email_routing_destination.go 66.25% <0.00%> (-0.42%) ⬇️
tunnel.go 41.39% <ø> (ø)

@jacobbednarz jacobbednarz merged commit 126ef3e into cloudflare:master May 31, 2023
@jacobbednarz jacobbednarz deleted the return-actual-err branch May 31, 2023 01:36
@github-actions github-actions bot added this to the v0.69.0 milestone May 31, 2023
github-actions bot pushed a commit that referenced this pull request May 31, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

This functionality has been released in v0.69.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants