-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WR-1279 add waiting room zone-level settings #1276
Conversation
changelog detected ✅ |
0c62837
to
c8fac53
Compare
Codecov Report
@@ Coverage Diff @@
## master #1276 +/- ##
==========================================
- Coverage 49.23% 49.07% -0.17%
==========================================
Files 131 133 +2
Lines 12665 13032 +367
==========================================
+ Hits 6236 6395 +159
- Misses 4988 5143 +155
- Partials 1441 1494 +53
|
thanks for the PR @piperswe 🙇 the changes themselves look fine (minor nitpicks inline) however, for the method signatures, i'd recommend swapping to the method signature conventions outlined in the experimental documentation which allows more flexibility but stronger type guarantees for the future. if you're looking for some prior art, you can checkout #1270 which was a new resource added within the last couple of weeks that follows these conventions. i've also commented on one of the methods to help you get started. |
This functionality has been released in v0.67.0. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Description
This adds support for the new Waiting Room zone-level settings, which are used to enable search engine crawler bypass.
Has your change been tested?
Tests were added, mirroring the other tests
Screenshots (if appropriate):
Types of changes
What sort of change does your code introduce/modify?
Checklist: