-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for pages deployment auto pagination #1264
Add support for pages deployment auto pagination #1264
Conversation
changelog detected ✅ |
Codecov Report
@@ Coverage Diff @@
## master #1264 +/- ##
==========================================
+ Coverage 49.23% 49.40% +0.16%
==========================================
Files 131 131
Lines 12665 12719 +54
==========================================
+ Hits 6236 6284 +48
+ Misses 4988 4985 -3
- Partials 1441 1450 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
d9fb7d1
to
7376c32
Compare
7376c32
to
1e74748
Compare
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
I don't know what the plan is for the project name test, I know that the API will reject it if you try. Also, |
Pages, unfortunately, uses a friendly name for the identifier in the URL so to be able to update the `Name` value we need a way to differentiate the two. The way I've solved this here is that `ID` is used for addressing the resource via the UI or a stable identifier whereas `Name` is used for updating the value.
This functionality has been released in v0.73.0. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Description
Adds support for auto paginate for pages deployments. Support forcing deletion of a pages deployment.
Also removed an unused type and var.
Has your change been tested?
Updated existing tests and they pass.
Screenshots (if appropriate):
Types of changes
What sort of change does your code introduce/modify?
Checklist: