zone: make settings more flexible #1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
changelog detected ✅ |
For the life of this library, the settings have always been under the `/zones/:zone_id/settings` route which was an aggregate of all the settings. This was designed as a way to aggregate all of the settings in one place and had its place however, now we are breaking up the zone settings to their true paths and need to make the `Get` and `Update` zone settings compatible with this approach. This will enable teams to use their true paths instead of the prefixed or aggregate paths with no friction from the library.
jacobbednarz
force-pushed
the
make-zone-settings-more-flexible
branch
from
b0ff791
to
c300573
Compare
Codecov Report
@@ Coverage Diff @@
## master #1251 +/- ##
==========================================
+ Coverage 49.23% 49.31% +0.08%
==========================================
Files 131 131
Lines 12665 12685 +20
==========================================
+ Hits 6236 6256 +20
+ Misses 4988 4980 -8
- Partials 1441 1449 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
This functionality has been released in v0.64.0. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the life of this library, the settings have always been under the
/zones/:zone_id/settingsroute which was an aggregate of all the settings. This was designed as a way to aggregate all of the settings in one place and had its place however, now we are breaking up the zone settings to their true paths and need to make theGetandUpdatezone settings compatible with this approach.This will enable teams to use their true paths instead of the prefixed or aggregate paths with no friction from the library (or upstreams like Terraform).