Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AUTH-5081 Add claims and scopes fields to Access IDP config #1237

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

veggiedefender
Copy link

Description

Adds the claims and scopes fields to the AccessIdentityProviderConfiguration struct, so that we can add it to Terraform as part of AUTH-5081

Has your change been tested?

Tested it locally to update the claims and scopes of my configured OIDC connector.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 16, 2023

changelog detected ✅

@codecov-commenter
Copy link

Codecov Report

Merging #1237 (453482c) into master (9ac4a16) will decrease coverage by 0.07%.
The diff coverage is 41.81%.

@@            Coverage Diff             @@
##           master    #1237      +/-   ##
==========================================
- Coverage   49.31%   49.24%   -0.07%     
==========================================
  Files         130      131       +1     
  Lines       12557    12667     +110     
==========================================
+ Hits         6192     6238      +46     
- Misses       4940     4988      +48     
- Partials     1425     1441      +16     
Impacted Files Coverage Δ
access_identity_provider.go 70.00% <ø> (ø)
addressing_ip_prefix.go 45.45% <ø> (ø)
convert_types.go 2.01% <ø> (ø)
addressing_address_map.go 39.04% <39.04%> (ø)
resource.go 83.33% <100.00%> (+4.38%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jacobbednarz
Copy link
Member

👋 are you able to link me to the public docs for this one? i'm not able to find these specific fields.

@veggiedefender
Copy link
Author

I added the claims field minutes ago (it might take some time to appear in the published docs), and the scopes field is already there. However, our IDP docs are a little bit broken right now. On this page, click "object" and then select the eighth option: https://developers.cloudflare.com/api/operations/access-identity-providers-add-an-access-identity-provider

Screenshot 2023-03-17 at 3 29 37 PM Screenshot 2023-03-17 at 3 29 53 PM

Not ideal but we're working on it..

@jacobbednarz
Copy link
Member

perfecto, thanks.

@github-actions
Copy link
Contributor

This functionality has been released in v0.64.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants