-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change StreamVideo.Duration type from int to float64. #1190
Change StreamVideo.Duration type from int to float64. #1190
Conversation
changelog detected ✅ |
Codecov Report
@@ Coverage Diff @@
## master #1190 +/- ##
==========================================
- Coverage 49.40% 49.36% -0.05%
==========================================
Files 127 128 +1
Lines 12290 12430 +140
==========================================
+ Hits 6072 6136 +64
- Misses 4840 4890 +50
- Partials 1378 1404 +26
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Thanks @ryotarai for the change! We have a change internally that will be pushed through this week to update the public-facing docs as well. |
This functionality has been released in v0.69.0. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Description
Calling
StreamListVideos
raises the following exception because StreamVideo.Duration is int but Cloudflare API returns a decimal number:Has your change been tested?
Yes. All unit tests has passed and calling StreamListVideos on our account has succeeded.
Types of changes
This is a bug fix and breaks compatibility (a little) because Duration type has been changed.
Checklist:
Closes #1096