-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for DNS comments and tags #1151
Support for DNS comments and tags #1151
Conversation
changelog detected ✅ |
Codecov Report
@@ Coverage Diff @@
## master #1151 +/- ##
==========================================
+ Coverage 49.40% 49.46% +0.06%
==========================================
Files 127 127
Lines 12290 12303 +13
==========================================
+ Hits 6072 6086 +14
+ Misses 4840 4839 -1
Partials 1378 1378
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Wow, thanks for this @Cyb3r-Jak3! Just noticed the merge conflict on #1158, turns out because you already added it! 🎉 |
This functionality has been released in v0.58.0. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Description
Adds support for the new DNS comments and tags. There is a breaking change because I updated DNSRecords to support the new listing pagination.
Has your change been tested?
New test has been created and all tests pass
Types of changes
What sort of change does your code introduce/modify?
Checklist: