Modernise Worker methods and conventions #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
changelog detected ✅ |
Updates all the available Workers endpoints to follow the new method signatures and conventions for calling the API.
Updates all the available Workers endpoints to follow the new method signatures and conventions for calling the API.
jacobbednarz
force-pushed
the
modernise-workers
branch
from
45fb88f
to
1c2393c
Compare
Codecov Report
@@ Coverage Diff @@
## master #1137 +/- ##
==========================================
- Coverage 50.11% 49.66% -0.45%
==========================================
Files 121 125 +4
Lines 11722 12005 +283
==========================================
+ Hits 5874 5962 +88
- Misses 4565 4698 +133
- Partials 1283 1345 +62
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jacobbednarz
commented
Nov 30, 2022
| return WorkerRouteResponse{}, ErrMissingIdentifier | ||
| } | ||
|
|
||
| uri := fmt.Sprintf("/zones/%s/workers/routes", rc.Identifier) |
There was a problem hiding this comment.
worker routes still use the /workers/routes endpoint instead of the services route as that isn't documented. once we have that documented, we can swap it over.
|
This functionality has been released in v0.57.0. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
ivan-section-io
pushed a commit
to section/cloudflare-go
that referenced
this pull request
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the 4.x release of the Terraform provider, we are removing the global
api.AccountIDthat is configured on the client due to ongoing issues with it (see cloudflare/terraform-provider-cloudflare#1646). Workers are the last set of methods that rely on this behaviour 🌟In doing this, we're also modernising the methods to match our future conventions and method signatures outlined for the experimental client.
This should be pretty well 1:1 functionality wise as everything Workers related is now accessible on the account resource level instead of the older split between zone/account for non-ent and enterprise configurations. The other major change here is that now the various parts of the Workers ecosystem are in their own files so that we can start to assign specific ownership rules instead of lumping it all together.