Expose result info messages #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobbednarz
force-pushed
the
expose-result-info-messages
branch
2 times, most recently
from
cf2084c
to
14877f6
Compare
|
changelog detected ✅ |
The messages field isn't really used broadly in the API as it was designed for informational feedback as opposed to errors, however, the page rules endpoint uses it to communicate validation failures. For these messages to be raised in other tools, namely the Terraform provider, it needs a dedicated field on the struct and to be included in the `Error()` method. Closes cloudflare/terraform-provider-cloudflare#1579
jacobbednarz
force-pushed
the
expose-result-info-messages
branch
from
14877f6
to
8a60321
Compare
|
This functionality has been released in v0.53.0. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The messages field isn't really used broadly in the API as it was designed for
informational feedback as opposed to errors, however, the page rules endpoint
uses it to communicate validation failures. For these messages to be raised in
other tools, namely the Terraform provider, it needs a dedicated field on the
struct and to be included in the
Error()method.Closes cloudflare/terraform-provider-cloudflare#1579