Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add waiting room rules #1102

Merged
merged 4 commits into from
Oct 21, 2022
Merged

Conversation

broswen
Copy link
Contributor

@broswen broswen commented Oct 7, 2022

Description

Add methods for the management of Waiting Room Rules.

Has your change been tested?

Unit tests have been created to confirm JSON marshaling works and the correct endpoints/methods are called.

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2022

changelog detected ✅

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2022

Codecov Report

Merging #1102 (446e863) into master (e39278e) will increase coverage by 0.12%.
The diff coverage is 57.00%.

@@            Coverage Diff             @@
##           master    #1102      +/-   ##
==========================================
+ Coverage   49.94%   50.07%   +0.12%     
==========================================
  Files         115      117       +2     
  Lines       10991    11441     +450     
==========================================
+ Hits         5490     5729     +239     
- Misses       4338     4475     +137     
- Partials     1163     1237      +74     
Impacted Files Coverage Δ
device_posture_rule.go 61.80% <ø> (ø)
errors.go 40.57% <ø> (ø)
pages_project.go 50.81% <ø> (ø)
rulesets.go 35.09% <ø> (ø)
stream.go 64.91% <ø> (ø)
teams_accounts.go 53.84% <ø> (ø)
teams_devices.go 52.63% <ø> (ø)
user_agent.go 0.00% <0.00%> (ø)
split_tunnel.go 40.38% <26.92%> (-13.47%) ⬇️
waiting_room.go 46.71% <38.46%> (-3.56%) ⬇️
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jacobbednarz
Copy link
Member

thanks for this @broswen 🏆 i've pushed a couple of changes to this that i wanted to highlight as a FYI

feel free to ping me on the internal PR for the docs if you haven't already and i'll merge this once it's in the pipeline.

@broswen
Copy link
Contributor Author

broswen commented Oct 20, 2022

@jacobbednarz docs are live, updated the PR.

.changelog/1102.txt Outdated Show resolved Hide resolved
@jacobbednarz jacobbednarz merged commit 8bc10e3 into cloudflare:master Oct 21, 2022
@jacobbednarz
Copy link
Member

thanks @broswen 👏

@github-actions github-actions bot added this to the v0.53.0 milestone Oct 21, 2022
github-actions bot pushed a commit that referenced this pull request Oct 21, 2022
@github-actions
Copy link
Contributor

This functionality has been released in v0.53.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants