Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WDAPI-678 add device settings policies APIs #1090

Conversation

TylerStanish
Copy link

Add Zero Trust device settings policy APIs

Description

Add endpoints to allow ZT admins to create device settings policies scoped to particular users and groups using wirefilter. Additionally, allow split tunnel and fallback domain configuration for the device settings policies.

Has your change been tested?

Yes, with unit tests

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (pending)
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2022

changelog detected ✅

@codecov-commenter
Copy link

Codecov Report

Merging #1090 (cf14cdc) into master (e39278e) will increase coverage by 0.20%.
The diff coverage is 56.82%.

@@            Coverage Diff             @@
##           master    #1090      +/-   ##
==========================================
+ Coverage   49.94%   50.15%   +0.20%     
==========================================
  Files         115      117       +2     
  Lines       10991    11363     +372     
==========================================
+ Hits         5490     5699     +209     
- Misses       4338     4443     +105     
- Partials     1163     1221      +58     
Impacted Files Coverage Δ
device_posture_rule.go 61.80% <ø> (ø)
errors.go 40.57% <ø> (ø)
pages_project.go 50.81% <ø> (ø)
stream.go 64.91% <ø> (ø)
teams_accounts.go 53.84% <ø> (ø)
teams_devices.go 52.63% <ø> (ø)
split_tunnel.go 40.38% <26.92%> (-13.47%) ⬇️
fallback_domain.go 41.17% <41.17%> (ø)
devices_policy.go 49.47% <49.29%> (-0.53%) ⬇️
access_service_tokens.go 66.29% <53.84%> (-2.13%) ⬇️
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


// CreateDeviceSettingsPolicy creates a settings policy against devices that match the policy
//
// API reference: TBA.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending this URL for documentation


// UpdateDefaultDeviceSettingsPolicy updates the default settings policy for an account
//
// API reference: TBA.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


// UpdateDeviceSettingsPolicy updates a settings policy
//
// API reference: TBA.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// DeleteDeviceSettingsPolicy deletes a settings policy and returns a list
// of all of the other policies in the account
//
// API reference: TBA.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


// GetDefaultDeviceSettings gets the default device settings policy
//
// API reference: TBA.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


// GetDefaultDeviceSettings gets the device settings policy by its policyID
//
// API reference: TBA.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@jacobbednarz jacobbednarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once we have the public docs for this, i'm 👍

@TylerStanish TylerStanish force-pushed the tstanish/WDAPI-678-device-settings-policies branch 2 times, most recently from 08e77df to 6a6c6e5 Compare September 28, 2022 21:12
@TylerStanish TylerStanish force-pushed the tstanish/WDAPI-678-device-settings-policies branch from 6a6c6e5 to 409c2dc Compare September 28, 2022 21:13
@jacobbednarz jacobbednarz merged commit 9e46011 into cloudflare:master Sep 28, 2022
@jacobbednarz
Copy link
Member

nice one @TylerStanish!

@github-actions github-actions bot added this to the v0.52.0 milestone Sep 28, 2022
github-actions bot pushed a commit that referenced this pull request Sep 28, 2022
@github-actions
Copy link
Contributor

This functionality has been released in v0.52.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants