Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Pages Projects with more stuff #1065

Merged

Conversation

Cyb3r-Jak3
Copy link
Contributor

Description

Adds field, production_branch, to pages project and deployments.

Has your change been tested?

Updated unit tests and they pass

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs. soon:tm:

@github-actions
Copy link
Contributor

changelog detected ✅

@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2022

Codecov Report

Merging #1065 (ce08d71) into master (e39278e) will increase coverage by 0.09%.
The diff coverage is 72.85%.

@@            Coverage Diff             @@
##           master    #1065      +/-   ##
==========================================
+ Coverage   49.94%   50.04%   +0.09%     
==========================================
  Files         115      116       +1     
  Lines       10991    11047      +56     
==========================================
+ Hits         5490     5528      +38     
- Misses       4338     4350      +12     
- Partials     1163     1169       +6     
Impacted Files Coverage Δ
pages_project.go 50.81% <ø> (ø)
stream.go 64.91% <ø> (ø)
teams_accounts.go 53.84% <ø> (ø)
api_shield.go 53.84% <53.84%> (ø)
workers.go 69.38% <72.72%> (-0.04%) ⬇️
cloudflare.go 68.42% <93.75%> (+1.21%) ⬆️
email_routing_settings.go 60.00% <100.00%> (ø)
images.go 50.34% <100.00%> (-0.35%) ⬇️
r2_bucket.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

pages_project.go Outdated Show resolved Hide resolved
pages_project.go Outdated Show resolved Hide resolved
@Cyb3r-Jak3 Cyb3r-Jak3 marked this pull request as draft August 26, 2022 23:56
@WalshyDev
Copy link
Member

Big API doc PR is up 😆

Let's make sure everything is synced 👍

@Cyb3r-Jak3 Cyb3r-Jak3 marked this pull request as ready for review August 27, 2022 01:54
@Cyb3r-Jak3
Copy link
Contributor Author

Pretty sure I got everything that is being added to the docs. Will have @WalshyDev verify

@Cyb3r-Jak3 Cyb3r-Jak3 requested review from WalshyDev and removed request for jacobbednarz August 27, 2022 01:55
@Cyb3r-Jak3 Cyb3r-Jak3 changed the title Pages project production branch Updates Pages Projects with more stuff Aug 27, 2022
pages_project.go Outdated Show resolved Hide resolved
pages_project.go Outdated Show resolved Hide resolved
pages_project.go Show resolved Hide resolved
pages_project.go Outdated Show resolved Hide resolved
@WalshyDev
Copy link
Member

I believe these are all the properties indeed

Copy link
Member

@WalshyDev WalshyDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jacobbednarz
Copy link
Member

LGTM. tracking this one against the internal PRs and lines up from what i can see, thanks!

@jacobbednarz jacobbednarz merged commit c48d484 into cloudflare:master Aug 29, 2022
@github-actions github-actions bot added this to the v0.49.0 milestone Aug 29, 2022
github-actions bot pushed a commit that referenced this pull request Aug 29, 2022
@Cyb3r-Jak3 Cyb3r-Jak3 deleted the pages-project-production_branch branch August 29, 2022 00:29
@github-actions
Copy link
Contributor

This functionality has been released in v0.49.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants