Remove double-unmarshalling

[vazexqi]

Description

Fixes #1045

Has your change been tested?

Modified existing tests and ran go test.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.
• This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

[github-actions]

changelog detected ✅

[vazexqi]

This is a slightly different bug but also has to do with the marshalling/unmarshalling of the config param.

[vazexqi]

I am new to this process so let me know if there's anything that I'm missing.
In the mean time, I am using my forked version at https://github.com/zuplo/cloudflare-go to unblock myself.

[jacobbednarz]

let me confirm with the service team as this was the correct API response when it was added.

[jacobbednarz]

this should be renamed now to better reflect it's use

[vazexqi]

I think it can be removed now (see my latest PR).

I think this is OK. It's not safe since it can be breaking because TunnelConfigurationStringifiedConfigResult was an exported type before in the SDK but I doubt anyone was directly referencing those types.

[codecov-commenter]

Codecov Report

Merging #1046 (87eb8f9) into master (6c5ea4a) will increase coverage by 0.88%.
The diff coverage is 65.04%.

@@            Coverage Diff             @@
##           master    #1046      +/-   ##
==========================================
+ Coverage   49.06%   49.94%   +0.88%     
==========================================
  Files         108      115       +7     
  Lines       10428    10991     +563     
==========================================
+ Hits         5116     5490     +374     
- Misses       4200     4338     +138     
- Partials     1112     1163      +51     

Impacted Files	Coverage Δ
access_application.go	76.52% <ø> (ø)
access_bookmark.go	72.44% <ø> (ø)
workers_account_settings.go	35.71% <35.71%> (ø)
rulesets.go	35.09% <47.36%> (+7.43%)	⬆️
workers_tail.go	52.00% <52.00%> (ø)
workers_subdomain.go	57.14% <57.14%> (ø)
email_routing_settings.go	60.00% <60.00%> (ø)
email_routing_rules.go	65.64% <65.64%> (ø)
lockdown.go	57.69% <66.00%> (+6.94%)	⬆️
email_routing_destination.go	66.25% <66.25%> (ø)
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[jacobbednarz]

this still needs a CHANGELOG too

[jacobbednarz]

thanks for getting this over the line 🎉

[vazexqi]

@jacobbednarz - Thanks for helping with this PR. Do you know when you will cut a new release so that I can switch over to the official version instead of my fork?

[jacobbednarz]

details in https://github.com/cloudflare/cloudflare-go/blob/master/docs/release-process.md.

you can also check the milestone that this PR was added to.

[github-actions]

This functionality has been released in v0.48.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!