Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump golang.org/x/tools/gopls from 0.9.3 to 0.9.4 #1044

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 16, 2022

Bumps golang.org/x/tools/gopls from 0.9.3 to 0.9.4.

Release notes

Sourced from golang.org/x/tools/gopls's releases.

gopls/v0.9.4

This release fixes an unfortunate bug in a new vet analysis in the [email protected] release. Specifically, a stray print statement in a new analyzer for the invalid time format string "2006-02-01", which corrupts gopls' communication over STDIN/STDOUT.

This only affects projects using that bad format string, and only when a file in the affected package is open. Thanks to @​Phadin for accurately identifying this bug so quickly after it was introduced. Issue golang/go#54459 tracks our follow-up to prevent similar regressions from making it into future gopls releases.

On a positive note, here is the new vet analysis in action. Clearly it will catch real bugs!

image

Commits
  • d6c4dc0 gopls: update go.mod for v0.9.4
  • 3f9b119 internal/lsp/debug: update hard-coded version for v0.9.4
  • bf677ca [gopls-release-branch.0.9] go/analysis: remove stray print statement in the t...
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [golang.org/x/tools/gopls](https://github.com/golang/tools) from 0.9.3 to 0.9.4.
- [Release notes](https://github.com/golang/tools/releases)
- [Commits](golang/tools@gopls/v0.9.3...gopls/v0.9.4)

---
updated-dependencies:
- dependency-name: golang.org/x/tools/gopls
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #1044 (000d5d3) into master (6c5ea4a) will increase coverage by 0.67%.
The diff coverage is 62.85%.

❗ Current head 000d5d3 differs from pull request most recent head a515d93. Consider uploading reports for the commit a515d93 to get more accurate results

@@            Coverage Diff             @@
##           master    #1044      +/-   ##
==========================================
+ Coverage   49.06%   49.73%   +0.67%     
==========================================
  Files         108      115       +7     
  Lines       10428    10977     +549     
==========================================
+ Hits         5116     5459     +343     
- Misses       4200     4351     +151     
- Partials     1112     1167      +55     
Impacted Files Coverage Δ
access_application.go 76.52% <ø> (ø)
access_bookmark.go 72.44% <ø> (ø)
workers_account_settings.go 35.71% <35.71%> (ø)
rulesets.go 35.09% <47.36%> (+7.43%) ⬆️
workers_tail.go 52.00% <52.00%> (ø)
workers_subdomain.go 57.14% <57.14%> (ø)
email_routing_settings.go 60.00% <60.00%> (ø)
email_routing_rules.go 65.64% <65.64%> (ø)
lockdown.go 57.69% <66.00%> (+6.94%) ⬆️
email_routing_destination.go 66.25% <66.25%> (ø)
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jacobbednarz jacobbednarz merged commit d9edd4f into master Aug 16, 2022
@jacobbednarz jacobbednarz deleted the dependabot/go_modules/golang.org/x/tools/gopls-0.9.4 branch August 16, 2022 19:37
@github-actions github-actions bot added this to the v0.47.0 milestone Aug 16, 2022
github-actions bot pushed a commit that referenced this pull request Aug 16, 2022
@github-actions
Copy link
Contributor

This functionality has been released in v0.47.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants