Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add worker account settings #1027

Merged
merged 3 commits into from
Aug 9, 2022

Conversation

Cyb3r-Jak3
Copy link
Contributor

@Cyb3r-Jak3 Cyb3r-Jak3 commented Aug 8, 2022

Description

Adds support for workers account settings: https://api.cloudflare.com/#worker-account-settings-properties

Has your change been tested?

Created units tests and they pass

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2022

changelog detected ✅

@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2022

Codecov Report

Merging #1027 (607456d) into master (6c5ea4a) will decrease coverage by 0.03%.
The diff coverage is 35.71%.

@@            Coverage Diff             @@
##           master    #1027      +/-   ##
==========================================
- Coverage   49.06%   49.02%   -0.04%     
==========================================
  Files         108      109       +1     
  Lines       10428    10456      +28     
==========================================
+ Hits         5116     5126      +10     
- Misses       4200     4212      +12     
- Partials     1112     1118       +6     
Impacted Files Coverage Δ
access_application.go 76.52% <ø> (ø)
access_bookmark.go 72.44% <ø> (ø)
workers_account_settings.go 35.71% <35.71%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jacobbednarz
Copy link
Member

pulled over the same feedback from #1026

@jacobbednarz jacobbednarz merged commit c4b9df0 into cloudflare:master Aug 9, 2022
@jacobbednarz
Copy link
Member

thanks! this is awesome stuff!

@github-actions github-actions bot added this to the v0.47.0 milestone Aug 9, 2022
github-actions bot pushed a commit that referenced this pull request Aug 9, 2022
@Cyb3r-Jak3 Cyb3r-Jak3 deleted the workers_account_settings branch August 9, 2022 03:02
@github-actions
Copy link
Contributor

This functionality has been released in v0.47.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants