use CreateChallengeWidgetRequest to create ChallengeWidgets

cloudflare · Apr 15, 2023 · 7fdb309 · 7fdb309
1 parent 723fc94
commit 7fdb309
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/challenge_widgets.go b/challenge_widgets.go
@@ -23,6 +23,15 @@ type ChallengeWidget struct {
 	Region       string     `json:"region,omitempty"`
 }
 
+type CreateChallengeWidgetRequest struct {
+	Name         string   `json:"name,omitempty"`
+	Domains      []string `json:"domains,omitempty"`
+	Mode         string   `json:"mode,omitempty"`
+	BotFightMode bool     `json:"bot_fight_mode,omitempty"`
+	Region       string   `json:"region,omitempty"`
+	OffLabel     bool     `json:"off_label,omitempty"`
+}
+
 type ChallengeWidgetResponse struct {
 	Response
 	Result ChallengeWidget `json:"result"`
@@ -48,7 +57,7 @@ type RotateChallengeWidgetRequest struct {
 // CreateChallengeWidget creates a new challenge widgets.
 //
 // API reference: https://api.cloudflare.com/#challenge-widgets-properties
-func (api *API) CreateChallengeWidget(ctx context.Context, rc *ResourceContainer, params ChallengeWidget) (ChallengeWidget, error) {
+func (api *API) CreateChallengeWidget(ctx context.Context, rc *ResourceContainer, params CreateChallengeWidgetRequest) (ChallengeWidget, error) {
 	if rc.Identifier == "" {
 		return ChallengeWidget{}, ErrMissingAccountID
 	}

diff --git a/challenge_widgets_test.go b/challenge_widgets_test.go
@@ -63,12 +63,12 @@ func TestChallengeWidgets_Create(t *testing.T) {
 	})
 
 	// Make sure missing account ID is thrown
-	_, err := client.CreateChallengeWidget(context.Background(), AccountIdentifier(""), ChallengeWidget{})
+	_, err := client.CreateChallengeWidget(context.Background(), AccountIdentifier(""), CreateChallengeWidgetRequest{})
 	if assert.Error(t, err) {
 		assert.Equal(t, ErrMissingAccountID, err)
 	}
 
-	out, err := client.CreateChallengeWidget(context.Background(), AccountIdentifier(testAccountID), ChallengeWidget{
+	out, err := client.CreateChallengeWidget(context.Background(), AccountIdentifier(testAccountID), CreateChallengeWidgetRequest{
 		Name:         "blog.cloudflare.com login form",
 		Mode:         "invisible",
 		BotFightMode: true,