Merge pull request #1499 from rexscaria/rex/update-antivirus-teams-no…

…tification-settings feat: update teams antivirus settings to configure notification
cloudflare · Feb 13, 2024 · 59a2279 · 59a2279
2 parents ffa96c9 + 9d5edcb
commit 59a2279
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 7 deletions.
diff --git a/.changelog/1499.txt b/.changelog/1499.txt
@@ -0,0 +1,3 @@
+```release-note:enhancement
+teams_rules: `AntiVirus` settings includes notification settings
+```
diff --git a/teams_accounts.go b/teams_accounts.go
@@ -54,9 +54,10 @@ type BrowserIsolation struct {
 }
 
 type TeamsAntivirus struct {
-	EnabledDownloadPhase bool `json:"enabled_download_phase"`
-	EnabledUploadPhase   bool `json:"enabled_upload_phase"`
-	FailClosed           bool `json:"fail_closed"`
+	EnabledDownloadPhase bool                       `json:"enabled_download_phase"`
+	EnabledUploadPhase   bool                       `json:"enabled_upload_phase"`
+	FailClosed           bool                       `json:"fail_closed"`
+	NotificationSettings *TeamsNotificationSettings `json:"notification_settings"`
 }
 
 type TeamsFIPS struct {

diff --git a/teams_accounts_test.go b/teams_accounts_test.go
@@ -54,8 +54,13 @@ func TestTeamsAccountConfiguration(t *testing.T) {
 			"result": {
 				"settings": {
 					"antivirus": {
-						"enabled_download_phase": true
-					},
+					"enabled_download_phase": true,
+						"notification_settings": {
+					  		"enabled":true,
+					   		"msg":"msg",
+					   		"support_url":"https://hi.com"
+						}
+				 	},
 					"tls_decrypt": {
 						"enabled": true
 					},
@@ -82,7 +87,7 @@ func TestTeamsAccountConfiguration(t *testing.T) {
 					"browser_isolation": {
 						"url_browser_isolation_enabled": true,
 						"non_identity_enabled": true
-          				},
+					},
 					"body_scanning": {
 						"inspection_mode": "deep"
 					},
@@ -101,7 +106,14 @@ func TestTeamsAccountConfiguration(t *testing.T) {
 
 	if assert.NoError(t, err) {
 		assert.Equal(t, actual.Settings, TeamsAccountSettings{
-			Antivirus:         &TeamsAntivirus{EnabledDownloadPhase: true},
+			Antivirus: &TeamsAntivirus{
+				EnabledDownloadPhase: true,
+				NotificationSettings: &TeamsNotificationSettings{
+					Enabled:    &trueValue,
+					Message:    "msg",
+					SupportURL: "https://hi.com",
+				},
+			},
 			ActivityLog:       &TeamsActivityLog{Enabled: true},
 			TLSDecrypt:        &TeamsTLSDecrypt{Enabled: true},
 			ProtocolDetection: &TeamsProtocolDetection{Enabled: true},