-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Chore] WASM code generation disallowed #14361
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments but directionally 🚀 and thank you!
Deploying cloudflare-docs with Cloudflare Pages
|
Files with changes (up to 15)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙂 Thanks 😄 🎉
But the points Brendan's making should be addressed before merging 🙂
Co-authored-by: Brendan Irvine-Broque <[email protected]>
Co-authored-by: Dario Piotrowicz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approving after having had a quick look at the wasm support 🙂
closes #13469