Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] WASM code generation disallowed #14361

Merged
merged 5 commits into from
May 6, 2024

Conversation

kodster28
Copy link
Contributor

closes #13469

Copy link
Contributor

@irvinebroque irvinebroque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments but directionally 🚀 and thank you!

Copy link

cloudflare-workers-and-pages bot commented May 2, 2024

Deploying cloudflare-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5453263
Status: ✅  Deploy successful!
Preview URL: https://c660b863.cloudflare-docs-7ou.pages.dev
Branch Preview URL: https://wasm-code-generation-disable.cloudflare-docs-7ou.pages.dev

View logs

Copy link
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙂 Thanks 😄 🎉

But the points Brendan's making should be addressed before merging 🙂

Copy link
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving after having had a quick look at the wasm support 🙂

@kodster28 kodster28 merged commit fa5ce3e into production May 6, 2024
7 checks passed
@kodster28 kodster28 deleted the wasm-code-generation-disabled branch May 6, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product:workers Related to Workers product size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document that Wasm code generation is disallowed
5 participants