-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deploy-an-angular-site.mdx #17946
Open
fahrnbach
wants to merge
5
commits into
cloudflare:production
Choose a base branch
from
fahrnbach:patch-4
base: production
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hotfix for Update Build Settings For angular. Fixed and working. Request to change PagesBuildPreset to this solution or add instructions to change the ng build command in package.json. Request to update the Angular preset on the dashboard to match. Seems like there are quite a few people with this issue. See: cloudflare/workers-sdk#5527 Also: https://stackoverflow.com/questions/78463333/fail-to-deploy-angular-project-on-cloudflare-pages/79151848#79151848 And: https://community.cloudflare.com/t/angular-app-deployed-to-pages-is-unavailable-on-domain/632745
fahrnbach
requested review from
IgorMinar,
dario-piotrowicz,
jculvey,
aninibread,
GregBrimble,
tanushree-sharma and
a team
as code owners
November 3, 2024 01:08
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 files reviewed, 2 total issue(s) found.
src/content/docs/pages/framework-guides/deploy-an-angular-site.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/pages/framework-guides/deploy-an-angular-site.mdx
Outdated
Show resolved
Hide resolved
github-actions
bot
assigned aninibread, dario-piotrowicz, GregBrimble, IgorMinar, jculvey and tanushree-sharma
Nov 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hotfix to Update Build Settings for Angular Deployment Tutorial. Fixed and working.
https://developers.cloudflare.com/pages/framework-guides/deploy-an-angular-site/
Following thie default project settings result in failed build.
Request to change PagesBuildPreset to this working solution or add instructions to
change the ng build command in package.json.
Request to update the Angular preset on the dashboard to match.
Seems like there are quite a few people with this issue.
See: cloudflare/workers-sdk#5527
Also: https://stackoverflow.com/questions/78463333/fail-to-deploy-angular-project-on-cloudflare-pages/79151848#79151848
And: https://community.cloudflare.com/t/angular-app-deployed-to-pages-is-unavailable-on-domain/632745